Signal ergo minor fixes #986
Conversation
There was a problem hiding this comment.
Thank you for the PR!
Deriving Debug does however not look like the correct thing to do as the underlying datastructures are not made for being printable.
Can you change to implement Debug manually on SignalReader/SignalWriter and just have it print something along the lines of SignalWriter { .. }?
|
Ok, will do! |
korken89
added
the
skip-changelog
SebKuzminsky
force-pushed
the
signal-ergo-minor-fixes
branch
from
aedab12 to
18ef898
Compare
|
I deviated from your suggestion a little bit: I'm happy to take the type out if you prefer, lmk. |
|
That's fine, can you have a look at the failing test? I think it's just a |
This facilitates e.g. `my_task::spawn(my_signal_reader).unwrap();`
SebKuzminsky
force-pushed
the
signal-ergo-minor-fixes
branch
from
18ef898 to
7773fc9
Compare
|
That fixed it, only took 3 tries 🙄 |
|
Thank you for the improvement, and no worries! |
|
Haha, fascilitates, facilitates, tomato tomAto! 😅 Thanks! |
This fixes a couple of docs typos and derives Debug for Signal, SignalReader, and SignalWriter (and CriticalSectionWakerRegistration).
Having Debug available enables e.g.
my_task::spawn(my_signal_reader).unwrap();