Update support/example for ESP32-C3 to use latest versions of dependencies #975

jessebraham · 2024-09-05T16:11:11Z

This updates the rtic and rtic-macros packages to handle some changes which have been made since support for the ESP32-C3 has been updated last. It additionally updates the sw_and_hw example for this device, which I have tested and verified using a ESP32-C3-DevKit-RUST-1 v1.2a board.

If there are any questions or concerns please let me know, I'm happy to make any requested changes.

This supersedes #973 as well, so that can be closed when/if this is merged.

jessebraham · 2024-09-05T16:12:23Z

examples/esp32c3/examples/sw_and_hw.rs

    }

    // do nothing in init
    #[init]
    fn init(_: init::Context) -> (Shared, Local) {
        println!("init");
        let peripherals = Peripherals::take();
-        let io = IO::new(peripherals.GPIO, peripherals.IO_MUX);
-        let mut button = io.pins.gpio9.into_pull_down_input();
+        let io = Io::new_no_bind_interrupt(peripherals.GPIO, peripherals.IO_MUX);


I will note that this is a bit of a rough edge for which we don't have a good solution yet. Essentially the issue is that Io::new() binds a handler to the GPIO interrupt for async functionality, so if we want to use this interrupt for other purposes (like in the sw_and_hw example, when creating the hardware task) then we need to not bind the interrupt in the constructor.

This is potentially a bit of a footgun, so I can add a comment here if necessary.

There is a tracking issue for this in the esp-hal repo, FYI: esp-rs/esp-hal#2009

jessebraham · 2024-09-05T16:30:11Z

I'm not sure what you'd like me to do about the QEMU failure, I would not expect this output to stay consistent (as we're seeing with this failure).

onsdagens · 2024-09-06T11:02:10Z

Tested this locally on the same board, and it seems to work as expected.

I've fixed up the QEMU expected output, applied my suggestions and opened a PR on your fork.

onsdagens · 2024-09-06T13:45:45Z

i see my review is set as pending, so i'm not sure if you can see my comments. in any case, i see now what you were saying about QEMU, the output does not match what is expected, and what actually happens when running on a board

i think we should keep QEMU around, adjust the expected output to the unexpected results and use it as a marker for when something is potentially wrong and needs to be run on a board.

jessebraham · 2024-09-06T14:07:31Z

I agree, it's probably worth keeping the checks around, however perhaps being a bit less strict with regards to the bootloader output would be best.

Anyway, with your changes merged CI is green here now at least, so thanks for that!

rtic/src/export/riscv_esp32c3.rs

onsdagens · 2024-09-11T07:14:26Z

i guess i just forgot to press submit, the comments are now outdated but i will leave them here for the record.

korken89 · 2024-09-29T04:22:53Z

Great work, thank you!

I just merged some changes from @onsdagens , could you double check this PR is still OK?
E.g. there was a reference to esp32c3 v0.22 in rtic-montonics now as well.

jessebraham · 2024-09-30T09:26:38Z

Thanks for taking a look. I have rebased my branch locally but am running into some issues with the monotonic example; will investigate further.

Might take me a few days to get to this, lots going on right now for me :)

korken89 · 2024-09-30T15:52:10Z

Thank you, no rush!

jessebraham · 2024-10-02T13:18:31Z

I've resolved the issues I had encountered with the monotonic example, seems to be working correctly now.

Unfortunately, again we are having issues with the checks on the QEMU output. Happy to make whatever changes here, but I am not very familiar with these checks so am not sure how best to resolve this long-term. I think that the bootloader output can probably be ignored entirely in the QEMU checks.

AfoHT · 2024-10-02T17:48:45Z

I agree z

I've resolved the issues I had encountered with the monotonic example, seems to be working correctly now.

Awesome! 🚀

Unfortunately, again we are having issues with the checks on the QEMU output. Happy to make whatever changes here, but I am not very familiar with these checks so am not sure how best to resolve this long-term. I think that the bootloader output can probably be ignored entirely in the QEMU checks.

I agree, bootloader is not the main part. Do you want to attempt implement the ignoring of bootloader output, or should we join forces on that one?

jessebraham · 2024-10-03T09:11:13Z

Do you want to attempt implement the ignoring of bootloader output, or should we join forces on that one?

Would be great if I could get a hand with that, please. New project at work will be consuming a fair bit of my brainpower and time for at least the next couple weeks here.

export DEBUGGING while running to get verbose boot env DEBUGGING=1 cargo xtask ...

AfoHT

🚀

jessebraham · 2024-10-16T19:41:50Z

Thank you for wrapping this up!

jessebraham commented Sep 5, 2024

View reviewed changes

jessebraham mentioned this pull request Sep 5, 2024

Added esp32c6 support #917

Open

4 tasks

onsdagens reviewed Sep 11, 2024

View reviewed changes

rtic/src/export/riscv_esp32c3.rs Outdated Show resolved Hide resolved

rtic/src/export/riscv_esp32c3.rs Outdated Show resolved Hide resolved

jessebraham force-pushed the fixes/update-esp32c3-example branch from 42ea00c to 3e7998c Compare October 2, 2024 13:04

jessebraham and others added 13 commits October 16, 2024 21:20

Update rtic package to use latest version of esp32c3 dependency

851f2bd

Update rtic-macros ESP32-C3 bindings to reflect changes in HAL

170357a

Update the ESP32-C3 examples to use latest versions of all dependencies

94d3747

Update changelogs

f53d33c

adjust expected qemu output, add compile-time checks

132a41f

remove runtime checks, this is checked at compile time

8054365

fix expected qemu output

29da266

Clean up interrupt enable code a bit

2fd756b

Update rtic-monotonic to use the latest PAC for ESP32-C3

04bdd04

Update CHANGELOG.md for rtic-monotonic

4c22ed0

ci: esp32c3: Format runner.sh

09dd14c

ci: esp32c3: Default to silent boot

29ddfb8

export DEBUGGING while running to get verbose boot env DEBUGGING=1 cargo xtask ...

ci: esp32c3: Update expected example output

f6fd6ba

AfoHT force-pushed the fixes/update-esp32c3-example branch from 0a8eeab to f6fd6ba Compare October 16, 2024 19:21

AfoHT enabled auto-merge October 16, 2024 19:21

AfoHT approved these changes Oct 16, 2024

View reviewed changes

AfoHT added this pull request to the merge queue Oct 16, 2024

Merged via the queue into rtic-rs:master with commit 1f6b6a4 Oct 16, 2024
55 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update support/example for ESP32-C3 to use latest versions of dependencies #975

Update support/example for ESP32-C3 to use latest versions of dependencies #975

jessebraham commented Sep 5, 2024 •

edited

Loading

jessebraham Sep 5, 2024 •

edited

Loading

jessebraham Sep 6, 2024 •

edited

Loading

jessebraham commented Sep 5, 2024

onsdagens commented Sep 6, 2024 •

edited

Loading

onsdagens commented Sep 6, 2024 •

edited

Loading

jessebraham commented Sep 6, 2024

onsdagens commented Sep 11, 2024

korken89 commented Sep 29, 2024 •

edited

Loading

jessebraham commented Sep 30, 2024

korken89 commented Sep 30, 2024

jessebraham commented Oct 2, 2024 •

edited

Loading

AfoHT commented Oct 2, 2024

jessebraham commented Oct 3, 2024

AfoHT left a comment

jessebraham commented Oct 16, 2024

Update support/example for ESP32-C3 to use latest versions of dependencies #975

Update support/example for ESP32-C3 to use latest versions of dependencies #975

Conversation

jessebraham commented Sep 5, 2024 • edited Loading

jessebraham Sep 5, 2024 • edited Loading

Choose a reason for hiding this comment

jessebraham Sep 6, 2024 • edited Loading

Choose a reason for hiding this comment

jessebraham commented Sep 5, 2024

onsdagens commented Sep 6, 2024 • edited Loading

onsdagens commented Sep 6, 2024 • edited Loading

jessebraham commented Sep 6, 2024

onsdagens commented Sep 11, 2024

korken89 commented Sep 29, 2024 • edited Loading

jessebraham commented Sep 30, 2024

korken89 commented Sep 30, 2024

jessebraham commented Oct 2, 2024 • edited Loading

AfoHT commented Oct 2, 2024

jessebraham commented Oct 3, 2024

AfoHT left a comment

Choose a reason for hiding this comment

jessebraham commented Oct 16, 2024

jessebraham commented Sep 5, 2024 •

edited

Loading

jessebraham Sep 5, 2024 •

edited

Loading

jessebraham Sep 6, 2024 •

edited

Loading

onsdagens commented Sep 6, 2024 •

edited

Loading

onsdagens commented Sep 6, 2024 •

edited

Loading

korken89 commented Sep 29, 2024 •

edited

Loading

jessebraham commented Oct 2, 2024 •

edited

Loading