Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI + apply some linting #560

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Update CI + apply some linting #560

merged 7 commits into from
Aug 7, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Aug 5, 2024

With usethis::use_github_action(). I tweaked the lintr action to use .lintr. This works! So it will be easier to update the action as needed with usethis::use_github_action("lint")

I used the advice here.
https://lintr.r-lib.org/articles/lintr.html?q=exclusions#excluding-files-completely

also update badges as recommended by usethis

@olivroy olivroy changed the title Update CI Update CI + apply some linting Aug 6, 2024
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit f54d9c8 into rstudio:main Aug 7, 2024
12 checks passed
@olivroy
Copy link
Contributor Author

olivroy commented Aug 7, 2024

you will need a similar fix here for the coverage axtion r-lib/actions#834

@olivroy olivroy deleted the ci branch November 26, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants