Adds new peginv1 below minimum test #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
add-new-legacy-pegin-below-minimum-test
to
rits-refactors-9-2024-integration
October 3, 2024 17:54
marcos-iov
reviewed
Oct 3, 2024
lib/tests/2wp.js
Outdated
| // The btc pegin tx is not marked as processed by the bridge | ||
| await assertPeginTxHashNotProcessed(btcPeginTxHash); | ||
|
|
||
| await assert2wpBalancesPeginRejectedBelowMinimum(initial2wpBalances, peginValueInSatoshis); |
There was a problem hiding this comment.
I needed a rebase.
jeremy-then
force-pushed
the
add-new-peginv1-below-minimum-test
branch
from
0e304d4 to
82eb475
Compare
|
marcos-iov
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 'should reject a basic pegin v1 with value exactly below minimum' test.
This test sends a pegin v1 with a value exactly below minimum (the minimum pegin value minus 1 satoshis), to assert that it should be rejected with rejection reason 5 (invalid amount).
Asserts that the sender funds are lost and that the sender's derived rsk address nor the pegin v1 rsk recipient address get any funds, but the federation balance is increased by the pegin amount while the Bridge doesn't mark that pegin tx as processed.