[pr] Fix check args type in function ngx_header_set.

[rryqszq4]

No description provided.

[joanhey]

Remember than in the Development branch, a lot of problems are fixed.

master...development

The tests also include new versions:
https://github.com/rryqszq4/ngx-php/actions/runs/9513653971

And with more variant versions, the tests are faster than before.

[joanhey]

🎉 It's working with PHP/8.4

[joanhey]

Pass the Techempower tests with PHP8.4, using the fiber branch.
Also work with mysql and pgsql.

The plain PHP tests are a lot faster with PHP8.4, so we can have the same gain.

The final date for new commits is ~Jan 17, to be included in the next Round 23.

--------------------------------------------------------------------------------
Running Test: php-ngx
--------------------------------------------------------------------------------
php-ngx: Step 1/12 : FROM ubuntu:24.04
php-ngx:  ---> b1d9df8ab815
php-ngx: Step 2/12 : ARG DEBIAN_FRONTEND=noninteractive
php-ngx:  ---> Using cache
php-ngx:  ---> 2151ee62a23f
php-ngx: Step 3/12 : RUN apt-get update -yqq && apt-get install -yqq software-properties-common > /dev/null
php-ngx:  ---> Using cache
php-ngx:  ---> 421705cb3ef8
php-ngx: Step 4/12 : RUN LC_ALL=C.UTF-8 add-apt-repository ppa:ondrej/php > /dev/null &&     apt-get update -yqq > /dev/null && apt-get upgrade -yqq > /dev/null
php-ngx:  ---> Using cache
php-ngx:  ---> c17f502bb430
php-ngx: Step 5/12 : RUN apt-get update -yqq > /dev/null &&     apt-get install -yqq wget git libxml2-dev systemtap-sdt-dev                     zlib1g-dev libpcre3-dev libargon2-dev libsodium-dev libkrb5-dev                     php8.4-cli php8.4-dev libphp8.4-embed php8.4-mysql > /dev/null                                                                                            
php-ngx:  ---> Running in ecd91afaa0c7
php-ngx: debconf: delaying package configuration, since apt-utils is not installed
php-ngx:  ---> Removed intermediate container ecd91afaa0c7                                                                                                                                     
php-ngx:  ---> b4c3657e2b88
php-ngx: Step 6/12 : ENV NGINX_VERSION 1.27.3
php-ngx:  ---> Running in 098c57200be8
php-ngx:  ---> Removed intermediate container 098c57200be8
php-ngx:  ---> d7814d421b74
php-ngx: Step 7/12 : RUN git clone -b fiber --single-branch --depth 1 https://github.com/rryqszq4/ngx-php.git > /dev/null
php-ngx:  ---> Running in cd0d043c9993
php-ngx: Cloning into 'ngx-php'...
php-ngx:  ---> Removed intermediate container cd0d043c9993                                                                                                                                     
php-ngx:  ---> b6df27c395ea
php-ngx: Step 8/12 : RUN wget -q http://nginx.org/download/nginx-${NGINX_VERSION}.tar.gz &&     tar -zxf nginx-${NGINX_VERSION}.tar.gz &&     cd nginx-${NGINX_VERSION} &&     export PHP_LIB=/usr/lib &&     ./configure --user=www --group=www             --prefix=/nginx             --with-ld-opt="-Wl,-rpath,$PHP_LIB"             --add-module=/ngx-php/third_party/ngx_devel_kit             --add-module=/ngx-php > /dev/null &&     make > /dev/null && make install > /dev/null                                                                                                   
php-ngx:  ---> Running in 2ab0ed12551c
php-ngx:  ---> Removed intermediate container 2ab0ed12551c
php-ngx:  ---> d8deabdc36d1
php-ngx: Step 9/12 : RUN sed -i "s|opcache.jit=off|;opcache.jit=off|g" /etc/php/8.4/embed/conf.d/10-opcache.ini
php-ngx:  ---> Running in c0fb430a0b73
php-ngx:  ---> Removed intermediate container c0fb430a0b73
php-ngx:  ---> baddcd5723b4
php-ngx: Step 10/12 : COPY --link . .
php-ngx:  ---> a494e1c7cafd
php-ngx: Step 11/12 : EXPOSE 8080
php-ngx:  ---> Running in 41e46913f151
php-ngx:  ---> Removed intermediate container 41e46913f151
php-ngx:  ---> 1eee736bd588
php-ngx: Step 12/12 : CMD /nginx/sbin/nginx -c /deploy/nginx_default.conf
php-ngx:  ---> Running in 5a1340d925e1
php-ngx:  ---> Removed intermediate container 5a1340d925e1
php-ngx:  ---> 813c2d5cc8a5
php-ngx: [Warning] One or more build-args [BENCHMARK_ENV TFB_TEST_DATABASE TFB_TEST_NAME] were not consumed
php-ngx: Successfully built 813c2d5cc8a5
php-ngx: Successfully tagged techempower/tfb.test.php-ngx:latest
php-ngx: Build time: 1m 28s
Running docker container with cpu set: 
php-ngx: Verifying framework URLs
--------------------------------------------------------------------------------
VERIFYING JSON                                                                                                                                                                                 
--------------------------------------------------------------------------------
Accessing URL http://tfb-server:8080/json:                                                                                                                                                     
Accessing URL http://tfb-server:8080/json: 
   PASS for http://tfb-server:8080/json
--------------------------------------------------------------------------------
VERIFYING PLAINTEXT                                                                                                                                                                            
--------------------------------------------------------------------------------
Accessing URL http://tfb-server:8080/plaintext:                                                                                                                                                
Accessing URL http://tfb-server:8080/plaintext: 
   PASS for http://tfb-server:8080/plaintext
Auditing /FrameworkBenchmarks/frameworks/PHP/php-ngx:
No problems to report
wrk: Build time: 1s
php-ngx: Build time: 1m 28s
php-ngx: Time starting database: 0s
php-ngx: Time until accepting requests: 0s
php-ngx: Verify time: 7s
php-ngx: Total test time: 1m 38s
tfb: Total time building so far: 1m 29s
tfb: Total time verifying so far: 7s
tfb: Total execution time so far: 1m 39s
================================================================================
Verification Summary                                                                                                                                                                           
--------------------------------------------------------------------------------
| php-ngx                                                                                                                                                                                      
|       json          : PASS                                                                                                                                                                   
|       plaintext     : PASS                                                                                                                                                                   
================================================================================                                                                                                               
                                                                                                                                                                                               
Results are saved in /FrameworkBenchmarks/results/20250112113921 

[rryqszq4]

Remember than in the Development branch, a lot of problems are fixed.

master...development

The tests also include new versions: https://github.com/rryqszq4/ngx-php/actions/runs/9513653971

And with more variant versions, the tests are faster than before.

ok, I merged it from development and I will open a new pull request.

[rryqszq4]

Closed.