Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding metrics to show things people care about #7

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

LowKeyNerd
Copy link
Contributor

added watcher amounts and bridged amounts to the main section on the landing page

added watcher amounts and bridged amounts to the main section on the landing page
@LowKeyNerd
Copy link
Contributor Author

2024-06-01 11_40_18-Rosen Bridge

@vorujack vorujack requested a review from mkermani144 June 2, 2024 07:45
@@ -0,0 +1,15 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically don't commit IDE-specific code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if / when I'm going to get to any of this. You are are welcome to adjust this or just plug and play it into your existing content as you wish. It works and the community wants it, and that's the best I can do haha.

@@ -1,37 +1,76 @@
"use client";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a good idea to make the whole component a client component. Please extract the metrics section into an individual client component, leaving this one as-is.

@@ -0,0 +1,103 @@
"use client";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think It's a better idea to name the file the same as hook name.

@cannonQ
Copy link

cannonQ commented Jul 30, 2024

So --- what is needed to make this a reality? Not having visible stats for the Bridge is crazy IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants