Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lazy feature #476

Open
wants to merge 3 commits into
base: jazzy
Choose a base branch
from
Open

Add lazy feature #476

wants to merge 3 commits into from
+27 −16

Conversation

Tacha-S
Copy link
Contributor

@Tacha-S Tacha-S commented Jan 16, 2025

I have implemented support for the lazy feature, which was previously marked as TODO.

@SteveMacenski
Copy link
Member

Perfectly approve the PR, but CI is failing, so a test might need to be updated: https://build.ros2.org/job/Jpr__perception_pcl__ubuntu_noble_amd64/16/console and we need to have this in the ros2 branch so all future distributions have it as well (just open a repeated PR in ros2 once tests pass and we can merge the pair)

@Tacha-S Tacha-S mentioned this pull request Jan 17, 2025
Open
@Tacha-S
Copy link
Contributor Author

Tacha-S commented Jan 17, 2025

I was unsure whether it would be better to call createPublishers() in the derived class or to only address the issue with project_inliers. I would appreciate any opinions or suggestions on this.

Although I have passed all tests, it seems that the CI is not successful.
Additionally, due to changes in message_filters in #477 (#472), the CI fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tacha-S @SteveMacenski