Deprecating tf2 C Headers #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CursedRock17 <[email protected]>
mikeferguson
requested changes
Oct 29, 2024
| #include "tf2/LinearMath/Vector3.h" | ||
| #include "tf2/LinearMath/Quaternion.h" | ||
| #include "tf2/LinearMath/Vector3.hpp" | ||
| #include "tf2/LinearMath/Quaternion.hpp" |
There was a problem hiding this comment.
we should really wrap this with an if/else so that the branch continues to compile on older systems (since I expect this change to tf2 will only be released into rolling and later at this point):
#if __has_include(<tf2/convert.hpp>)
#include <tf2/convert.hpp>
#else
#include <tf2/convert.h>
#endif 
There was a problem hiding this comment.
we merged the cpp headers without the deprecation in humble and jazzy, I think it's save to merge this one
|
With the recent backports merged, this PR should be good for review. |
Changes in rolling are released in 0.40.0 - which is staged but not yet synced - CI won't pass until the next sync happens |
ahcorde
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this pull request in
geometry2in which we deprecated the.hstyle headers in favor of.hpp.