Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty on_shutdown() callbacks #1477

Merged
merged 1 commit into from
Jan 9, 2025

Remove empty on_shutdown()

8961e00
Select commit
Loading
Failed to load commit list.
Merged

Remove empty on_shutdown() callbacks #1477

Remove empty on_shutdown()
8961e00
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 0s

83.86% (+0.03%) compared to 7ddaf83

View this Pull Request on Codecov

83.86% (+0.03%) compared to 7ddaf83

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (7ddaf83) to head (8961e00).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1477      +/-   ##
==========================================
+ Coverage   83.83%   83.86%   +0.03%     
==========================================
  Files         122      122              
  Lines       11120    11113       -7     
  Branches      944      942       -2     
==========================================
- Hits         9322     9320       -2     
+ Misses       1489     1485       -4     
+ Partials      309      308       -1     
Files with missing lines Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 71.18% <ø> (+0.49%) ⬆️
...jectory_controller/joint_trajectory_controller.hpp 100.00% <ø> (ø)
...ory_controller/src/joint_trajectory_controller.cpp 83.93% <ø> (-0.03%) ⬇️
...nclude/tricycle_controller/tricycle_controller.hpp 100.00% <ø> (ø)
tricycle_controller/src/tricycle_controller.cpp 66.80% <ø> (+0.54%) ⬆️

... and 2 files with indirect coverage changes