Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in steering_controllers_lib #1464

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

christophfroehlich
Copy link
Contributor

Ackermann is a proper name and should be used as such.

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.81%. Comparing base (2375aca) to head (d657ae6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1464      +/-   ##
==========================================
- Coverage   83.83%   83.81%   -0.02%     
==========================================
  Files         122      122              
  Lines       11120    11122       +2     
  Branches      944      946       +2     
==========================================
  Hits         9322     9322              
  Misses       1489     1489              
- Partials      309      311       +2     
Flag Coverage Δ
unittests 83.81% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...g_controller/src/ackermann_steering_controller.cpp 80.00% <ø> (ø)
...roller/test/test_ackermann_steering_controller.hpp 86.59% <ø> (ø)
...ntroller/test/test_bicycle_steering_controller.hpp 83.11% <ø> (ø)
...llers_library/src/steering_controllers_library.cpp 79.72% <100.00%> (ø)
...library/test/test_steering_controllers_library.hpp 96.87% <ø> (ø)
...troller/test/test_tricycle_steering_controller.hpp 85.05% <ø> (ø)

... and 4 files with indirect coverage changes

@christophfroehlich christophfroehlich merged commit 0f2a683 into master Jan 2, 2025
23 of 24 checks passed
@christophfroehlich christophfroehlich deleted the fix/steeringlib_typo branch January 2, 2025 11:41
mergify bot pushed a commit that referenced this pull request Jan 2, 2025
christophfroehlich added a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants