-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up unused variable EPS in mecanum_drive_controller #1444
Clean up unused variable EPS in mecanum_drive_controller #1444
Conversation
…num_drive_controller.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi and thank you!
No reason in my opinion to keep it commented, just delete it.
@Mergifyio backport mergify/bp/humble/pr-512 |
✅ Backports have been created
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1444 +/- ##
==========================================
- Coverage 83.83% 83.81% -0.03%
==========================================
Files 122 122
Lines 11120 11121 +1
Branches 944 945 +1
==========================================
- Hits 9323 9321 -2
- Misses 1489 1490 +1
- Partials 308 310 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f23b7d8
into
ros-controls:master
(cherry picked from commit f23b7d8)
) (#1450) Co-authored-by: Shankar-Balajee <[email protected]>
closes: #1441
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
To send us a pull request, please:
colcon test
andpre-commit run
(requires you to install pre-commit bypip3 install pre-commit
)