Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Twist->TwistStamped in diff_drive_controller #1393

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

christophfroehlich
Copy link
Contributor

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.56%. Comparing base (9b344c7) to head (5b8df6f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...iff_drive_controller/src/diff_drive_controller.cpp 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1393      +/-   ##
==========================================
- Coverage   83.58%   83.56%   -0.03%     
==========================================
  Files         122      122              
  Lines       10984    10987       +3     
  Branches      936      937       +1     
==========================================
  Hits         9181     9181              
- Misses       1490     1492       +2     
- Partials      313      314       +1     
Flag Coverage Δ
unittests 83.56% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 76.42% <66.66%> (-0.59%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a fun one. At first I thought: Is he just changing the main interface, then I thought: wait a minute... :-D

@christophfroehlich
Copy link
Contributor Author

Someone has just not changed the alias when the unstamped twist support was dropped 😅 and I got confused when I worked on the realtime box changes..

@christophfroehlich christophfroehlich merged commit d8b30f8 into master Nov 27, 2024
20 checks passed
@christophfroehlich christophfroehlich deleted the diffdrive/rename_twist branch November 27, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants