Initial Kubeflow support #91
Open
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the environment variable `NB_PREFIX` is used, it is assumed rstudio is from kubeflow and thus userconf.sh will set `www-root-path` to `$NB_PREFIX`, set `www-port=8888` and it will disable auth. `RSTUDIO_VERSION=daily` or `RSTUDIO_VERSION=preview` need to be used (daily not working, preview not tested). On daily, the 404 page loads saying: ``` RSudio Server The requested page was not found. Please contact your system administrator for assistance, or click here to go back. ``` This was tested with a Dockerfile that exposes port 8888.
|
@davidspek This looks reasonable to me, do you still want this labeled as draft or shall we move forward? |
|
@cboettig Let me go over this again quickly. We now have an RStudio Dockerfile for Kubeflow which took a lot of work to get everything working correctly with conda and such. There might be some improvements we found while working on that which will be useful here as well. |
|
awesome, thanks, much appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the environment variable
NB_PREFIXis used, it is assumed rstudio is from kubeflow and thus userconf.sh will setwww-root-pathto$NB_PREFIX, setwww-port=8888and it will disable auth.RSTUDIO_VERSION=dailyorRSTUDIO_VERSION=previewneed to be used (daily not working, preview not tested). On daily, the 404 page loads saying:This was tested with a Dockerfile that exposes port 8888 rather than 8787 (Kubeflow expects 8888).