Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first pass of gpu smoke test #281
base: master
Are you sure you want to change the base?
first pass of gpu smoke test #281
Changes from 1 commit
fbc570b
5e4a5ba
a623852
2ef3245
10b6ea7
96d5855
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$(...)
may be preferable to`...`
. https://github.com/koalaman/shellcheck/wiki/SC2006There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eitsupi! I made the change as you suggested in my latest commit. I didn't realize backticks were deprecated. I'll try to use parentheses going forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason to use a US CRAN mirror?
rocker-versioned2/scripts/install_R.sh
Line 9 in a382d7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RobJY is this to trigger source installation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we need this line at all since tensorflow is installed in the containers by
scripts/install_tensorflow.sh
?When I attempt to run
exampls_tf.R
without it though I get the following error:Running
library(tensorflow)
in R gives a similar error message.Running
scripts/test-config-cuda.sh
reports the correct tensorflow version, but it's checking the version from Python withpython -c 'import tensorflow as tf; print(tf.__version__)'
.Do I need to add the path where tensorflow is installed by
scripts/install_tensorflow.sh
somewhere so R sees it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I wanted to point out is that the
repos
argument may simply be unnecessary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @eitsupi, you're right. It worked fine when I removed
repos
. Thanks! I've committed that change.It still seems like it shouldn't need to install that though. I tried adding the path
/opt/venv/reticulate
with the following code, but I got the same error:Is it fine to install
keras
here or does the fact that I need to install it indicate that there's an issue with the tensorflow install?