ignore suppress/noinspection names which don't fit the FindingName pa…

…ttern

fixes #827

modulecheck-finding/name/src/main/kotlin/modulecheck/finding/FindingName.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021-2022 Rick Busarow
+ * Copyright (C) 2021-2023 Rick Busarow
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -52,6 +52,18 @@ data class FindingName(
 
   companion object {
 
+    /**
+     * @return a [FindingName] if [maybeFindingName] is `kebab-case`, otherwise `null`.
+     * @since 0.12.4
+     */
+    fun safe(maybeFindingName: String): FindingName? {
+      return if (CaseMatcher.KebabCaseMatcher().matches(maybeFindingName)) {
+        FindingName(maybeFindingName)
+      } else {
+        null
+      }
+    }
+
     @Deprecated("This will be removed soon.")
     fun migrateLegacyIdOrNull(legacyID: String, logger: McLogger): String? {
 

modulecheck-parsing/gradle/dsl/internal/src/main/kotlin/modulecheck/parsing/gradle/dsl/internal/AbstractDependenciesBlock.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021-2022 Rick Busarow
+ * Copyright (C) 2021-2023 Rick Busarow
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -33,7 +33,6 @@ import modulecheck.parsing.gradle.model.ProjectPath.StringProjectPath
 import modulecheck.reporting.logging.McLogger
 import modulecheck.utils.lazy.ResetManager
 import modulecheck.utils.lazy.lazyResets
-import modulecheck.utils.mapToSet
 import modulecheck.utils.remove
 
 abstract class AbstractDependenciesBlock(
@@ -53,7 +52,9 @@ abstract class AbstractDependenciesBlock(
       allModuleDeclarations.forEach { (configuredModule, declarations) ->
 
         val cached = getOrPut(configuredModule) {
-          blockSuppressed.mapTo(mutableSetOf()) { FindingName(it) }
+          blockSuppressed
+            .mapNotNull { FindingName.safe(it) }
+            .mapTo(mutableSetOf()) { it }
         }
 
         declarations.forEach { moduleDependencyDeclaration ->
@@ -170,7 +171,7 @@ abstract class AbstractDependenciesBlock(
   }
 
   private fun Collection<String>.asFindingNames(): Set<FindingName> {
-    return mapToSet { FindingName(it) }
+    return mapNotNull { FindingName.safe(it) }.toSet()
   }
 
   override fun getOrEmpty(

modulecheck-parsing/gradle/dsl/internal/src/main/kotlin/modulecheck/parsing/gradle/dsl/internal/AbstractPluginsBlock.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021-2022 Rick Busarow
+ * Copyright (C) 2021-2023 Rick Busarow
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -21,7 +21,6 @@ import modulecheck.parsing.gradle.dsl.PluginsBlock
 import modulecheck.reporting.logging.McLogger
 import modulecheck.utils.lazy.ResetManager
 import modulecheck.utils.lazy.lazyResets
-import modulecheck.utils.mapToSet
 import java.io.File
 
 abstract class AbstractPluginsBlock(
@@ -48,7 +47,7 @@ abstract class AbstractPluginsBlock(
       _allDeclarations.forEach { pluginDeclaration ->
 
         val cached = getOrPut(pluginDeclaration) {
-          blockSuppressed.mapTo(mutableSetOf()) { FindingName(it) }
+          blockSuppressed.mapNotNullTo(mutableSetOf()) { FindingName.safe(it) }
         }
 
         cached += pluginDeclaration.suppressed.updateOldSuppresses()
@@ -101,7 +100,7 @@ abstract class AbstractPluginsBlock(
   }
 
   private fun Collection<String>.asFindingNames(): Set<FindingName> {
-    return mapToSet { FindingName(it) }
+    return mapNotNullTo(mutableSetOf()) { FindingName.safe(it) }
   }
 }
 

modulecheck-parsing/groovy-antlr/src/test/kotlin/modulecheck/parsing/groovy/antlr/GroovyDependencyBlockParserTest.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021-2022 Rick Busarow
+ * Copyright (C) 2021-2023 Rick Busarow
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -80,6 +80,20 @@ internal class GroovyDependenciesBlockParserTest : BaseTest() {
     )
   }
 
+  @Test
+  fun `suppression which doesn't match finding name regex should be ignored`() = parse(
+    """
+        //noinspection DSL_SCOPE_VIOLATION
+       dependencies {
+         api project(':core:android')
+         api project(':core:jvm')
+       }
+        """
+  ) {
+
+    allSuppressions.values.flatten() shouldBe emptyList()
+  }
+
   @Test
   fun `declaration with noinspection with old IDs should include suppressed with argument`() =
     parse(

modulecheck-parsing/groovy-antlr/src/test/kotlin/modulecheck/parsing/groovy/antlr/GroovyPluginsBlockParserTest.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021-2022 Rick Busarow
+ * Copyright (C) 2021-2023 Rick Busarow
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -119,6 +119,19 @@ internal class GroovyPluginsBlockParserTest : BaseTest() {
     )
   }
 
+  @Test
+  fun `suppression which doesn't match finding name regex should be ignored`() = parse(
+    """
+        //noinspection DSL_SCOPE_VIOLATION
+        plugins {
+          id 'com.squareup.anvil'
+        }
+        """
+  ) {
+
+    allSuppressions.values.flatten() shouldBe emptyList()
+  }
+
   @Test
   fun `suppress with old ID should be updated`() = parse(
     """

modulecheck-parsing/psi/src/test/kotlin/modulecheck/parsing/psi/KotlinDependenciesBlockParserTest.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021-2022 Rick Busarow
+ * Copyright (C) 2021-2023 Rick Busarow
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -111,6 +111,24 @@ internal class KotlinDependenciesBlockParserTest : ProjectTest() {
     )
   }
 
+  @Test
+  fun `suppression which doesn't match finding name regex should be ignored`() {
+    val block = parser
+      .parse(
+        """
+        @Suppress("DSL_SCOPE_VIOLATION")
+        dependencies {
+           api(project(":core:android"))
+           api(project(":core:jvm"))
+           @Suppress("DSL_SCOPE_VIOLATION")
+           testImplementation(project(":core:test"))
+        }
+         """
+      ).single()
+
+    block.allSuppressions.values.flatten() shouldBe emptyList()
+  }
+
   @Test
   fun `declaration with annotation should include annotation with argument`() {
     val block = parser

modulecheck-parsing/psi/src/test/kotlin/modulecheck/parsing/psi/KotlinPluginsBlockParserTest.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021-2022 Rick Busarow
+ * Copyright (C) 2021-2023 Rick Busarow
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -104,6 +104,20 @@ internal class KotlinPluginsBlockParserTest : BaseTest() {
     )
   }
 
+  @Test
+  fun `suppression which doesn't match finding name regex should be ignored`() {
+    val block = parse(
+      """
+        @Suppress("DSL_SCOPE_VIOLATION")
+        plugins {
+          id("com.squareup.anvil")
+        }
+        """
+    )
+
+    block.allSuppressions.values.flatten() shouldBe emptyList()
+  }
+
   @Test
   fun `suppressed id function`() {
     val block = parse(