Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated viz.js from 1.8.2 to 3.11.0 #525

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

Yinimi
Copy link
Contributor

@Yinimi Yinimi commented Dec 10, 2024

Hi,

Changes:

  • Updated wiz.js version
  • Fized call to pass the parameters

Description:
I was creating a diagram in the web on https://magjac.com/graphviz-visual-editor/ and the result didn't look the same when trying to get it run in RStudio / Bookdown.
Since viz.js was outdated it would not support all features and the result would look different.
related:

fyi @rich-iannone @krlmlr

There are probably several Issues that could be closed with this as well like for example:
#434
#432
#150 (there is a workaround described how to use other engine)

Copy link
Owner

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone
Copy link
Owner

@Yinimi Thanks so much for this PR! It's a valuable contribution :)

@rich-iannone rich-iannone merged commit e03fd30 into rich-iannone:main Dec 10, 2024
7 checks passed
rich-iannone added a commit that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants