avoid EFIv2 runtime services on Apple x86 machines #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardacatrinei
force-pushed
the
main
branch
from
3313fdf to
54c3e30
Compare
|
@vathpela can you take a look here? |
|
Does this make Apple's T2 chip recognise the signature? Or it just makes it bootable with secure boot turned off? |
|
This will help prevent a black screen when trying a distro based on shim. |
vathpela
force-pushed
the
main
branch
2 times, most recently
from
e5d23fd to
88e1022
Compare
While booting a MacBookPro15,2 (the last Intel model, 2019), shim 15.8 gets stuck in RT->QueryVariableInfo(). Previously, these devices shipped with EFI firmware version 1.10, and we had a quirk in place for this (rhboot#364). However, Apple updated the firmware to version 2.40, but it still doesn't implement runtime services. This patch adds a test for Apple as the vendor, and treats that as equivalent to having an older major UEFI version. Signed-off-by: Eduard Acatrinei <[email protected]>
|
I've made a small change to not trust that |
vathpela
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While booting a MacBookPro15,2 (the last Intel model, 2019).
The shim 15.8 got stuck in
RT->QueryVariableInfo().Previously, these devices shipped with EFI firmware version 1.10, and we had a quirk in place for this (#364)
However, Apple updated the firmware to version 2.40, but it still doesn't implement runtime services.
Logs and a screen recording have been attached to this comment.
#364 (comment)
Related to:
#385
#457
https://nvd.nist.gov/vuln/detail/CVE-2022-48769