Test import_mok_state() when MokListRT would be bigger than available size #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the tests maybe have more descriptive names than 0 and 1? And/Or comments would be nice, so you won't need to dig through commits later to find out what the test tests. |
Yeah, that's a big part of why this is still a draft. |
vathpela
force-pushed
the
test-mok-mirror-enospc
branch
from
3dc8189 to
a439ec2
Compare
frozencemetery
previously requested changes
Jun 8, 2022
vathpela
force-pushed
the
test-mok-mirror-enospc
branch
2 times, most recently
from
37de20a to
af376e5
Compare
When SetVariable() is called, currently the test for being out of space is correct, but the accounting is backwards - success adds more space available. This fixes the accounting and (with SHIM_DEBUG) logs the variable size. Signed-off-by: Peter Jones <[email protected]>
This splits up the API for setting default usage limits, adding a test API function to set alternate usage limits. Signed-off-by: Peter Jones <[email protected]>
This makes a generic test_mok_mirror() which can validate the result of (hopefully) any run of any result of import_mok_state(), and changes test_mok_mirror_0() to use it, and also documents what's being tested and the results it expects to see. Signed-off-by: Peter Jones <[email protected]>
This adds another test case for mirroring mok variables - in this case there is arbitrarily not enough space in the SetVariable() storage backend for some or all of the variables, and so some variables are mirrored to both variables and the config space storage, and some only to the config space storage. Currently the test only ensures that the out-of-resources condition on the variable storage is handled correctly; we don't (yet) test the config space. That's an avenue for future work. Signed-off-by: Peter Jones <[email protected]>
vathpela
force-pushed
the
test-mok-mirror-enospc
branch
from
af376e5 to
4eb84a0
Compare
jsetje
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set adds
test_mok_mirror_1(), which is basically liketest_mok_mirror_0()except with a variable size limit smaller thanMokListRTwould be, and with the.must_be_absentflag set totruein the test data, so the test will fail if the variable is successfully created or if the data is not in the mokvars config variable.