Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Issue #5954 #6633

Closed
wants to merge 2 commits into from
+10 −2
Closed

Fixing Issue #5954 #6633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3218a77
feat: in useForm.ts made the keepPreviousData as false in queryOptions
Ananmayd Jan 5, 2025
142bd40
Merge branch 'main' of https://github.com/Ananmayd/refine
Ananmayd Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thirty-rice-brush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@refinedev/antd": major
---

in queryoptions made the keepPreviousData as false so that user do not see the data of previous modal on opening the new one.
5 changes: 4 additions & 1 deletion packages/antd/src/hooks/form/useForm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,10 @@ export const useForm = <
onLiveEvent,
invalidates,
undoableTimeout,
queryOptions,
queryOptions: {
...queryOptions,
keepPreviousData: false,
},
createMutationOptions,
updateMutationOptions,
id: idFromProps,
Expand Down
2 changes: 1 addition & 1 deletion packages/antd/src/hooks/form/useModalForm/useModalForm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,6 @@ export const useModalForm = <
"Are you sure you want to leave? You have unsaved changes.",
),
);

if (warnWhenConfirm) {
setWarnWhen(false);
} else {
Expand All @@ -298,6 +297,7 @@ export const useModalForm = <
if (typeof showId !== "undefined") {
setId?.(showId);
}

const needsIdToOpen = action === "edit" || action === "clone";
const hasId = typeof showId !== "undefined" || typeof id !== "undefined";
if (needsIdToOpen ? hasId : true) {
Expand Down