Add test_dynamic_block_split to data_non_parallel #49866
+59
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinath Krishnamachari <[email protected]>
Signed-off-by: Srinath Krishnamachari <[email protected]>
aslonnie
reviewed
Jan 15, 2025
.buildkite/data.rayci.yml
Outdated
Comment on lines
150
to
151
| --workers "$${BUILDKITE_PARALLEL_JOB_COUNT}" | ||
| --worker-id "$${BUILDKITE_PARALLEL_JOB}" --parallelism-per-worker 1 |
There was a problem hiding this comment.
you can just remove the --workers "$${BUILDKITE_PARALLEL_JOB_COUNT}" --worker-id "$${BUILDKITE_PARALLEL_JOB}" --parallelism-per-worker 1
and remove the parallelism: 1 in the job definition too
Signed-off-by: srinathk10 <[email protected]>
bveeramani
approved these changes
Jan 16, 2025
| @@ -349,7 +349,7 @@ py_test( | |||
| name = "test_dynamic_block_split", | |||
| size = "medium", | |||
| srcs = ["tests/test_dynamic_block_split.py"], | |||
| tags = ["team:data", "exclusive"], | |||
| tags = ["team:data", "exclusive", "data_non_parallel"], | |||
There was a problem hiding this comment.
Could you add a comment explaining why we add the data_non_parallel tag?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Create a grouping to run data tests serially (non-parallel workers).
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.