Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] [cgraph] Check for regression on commit before check_signals #49856

Closed
wants to merge 1 commit into from

Conversation

dayshah
Copy link
Contributor

@dayshah dayshah commented Jan 15, 2025

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: dayshah <[email protected]>
@dayshah
Copy link
Contributor Author

dayshah commented Jan 15, 2025

There is a marked improvement here

exec_nccl_gpu = [3807.5419386589992, 125.95683203533575]

  | exec_ray_core_cpu = [246.8024749760428, 0.8536818868024344]
  | exec_ray_dag_cpu = [680.3783282032099, 14.881225617873563]
  | exec_ray_core_gpu = [236.64473534590152, 2.7947241961310225]
  | exec_ray_dag_gpu_cpu_gpu = [632.760913933743, 10.007032114777676]
  | exec_ray_dag_gpu_nccl_static_shape_direct_return = [898.9286433655346, 13.724355918208948]
  | exec_ray_dag_gpu_nccl_direct_return = [755.0576883986996, 5.7405665429623935]
  | exec_ray_dag_gpu_nccl_static_shape = [697.3562386858833, 10.011126323438742]
  | exec_ray_dag_gpu_nccl = [601.5813430101446, 5.458406729774993]
  | perf_metrics = [{'perf_metric_name': 'exec_nccl_gpu', 'perf_metric_value': 3807.5419386589992, 'perf_metric_type': 'THROUGHPUT'}, {'perf_metric_name': 'exec_ray_core_cpu', 'perf_metric_value': 246.8024749760428, 'perf_metric_type': 'THROUGHPUT'}, {'perf_metric_name': 'exec_ray_dag_cpu', 'perf_metric_value': 680.3783282032099, 'perf_metric_type': 'THROUGHPUT'}, {'perf_metric_name': 'exec_ray_core_gpu', 'perf_metric_value': 236.64473534590152, 'perf_metric_type': 'THROUGHPUT'}, {'perf_metric_name': 'exec_ray_dag_gpu_cpu_gpu', 'perf_metric_value': 632.760913933743, 'perf_metric_type': 'THROUGHPUT'}, {'perf_metric_name': 'exec_ray_dag_gpu_nccl_static_shape_direct_return', 'perf_metric_value': 898.9286433655346, 'perf_metric_type': 'THROUGHPUT'}, {'perf_metric_name': 'exec_ray_dag_gpu_nccl_direct_return', 'perf_metric_value': 755.0576883986996, 'perf_metric_type': 'THROUGHPUT'}, {'perf_metric_name': 'exec_ray_dag_gpu_nccl_static_shape', 'perf_metric_value': 697.3562386858833, 'perf_metric_type': 'THROUGHPUT'}, {'perf_metric_name': 'exec_ray_dag_gpu_nccl', 'perf_metric_value': 601.5813430101446, 'perf_metric_type': 'THROUGHPUT'}]

@dayshah dayshah changed the title [core] [cgraph] Check for regression from before check_signals [core] [cgraph] Check for regression on commit check_signals Jan 15, 2025
@dayshah dayshah changed the title [core] [cgraph] Check for regression on commit check_signals [core] [cgraph] Check for regression on commit before check_signals Jan 15, 2025
@dayshah dayshah closed this Jan 15, 2025
@dayshah dayshah deleted the find-dag-regression branch January 15, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant