Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDT - Remove Legacy Routing #8205

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lakshmimsft
Copy link
Contributor

@lakshmimsft lakshmimsft commented Jan 8, 2025

Description

  1. Remove Legacy Routing. Update tests as necessary
  2. Add global location, address to manifests. Include them in ucp images.

Type of change

Part of: #6688

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

@lakshmimsft lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 3c22547 to 94382b0 Compare January 8, 2025 17:47
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 8, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref 94382b0
Unique ID funcd3eb7cf3c1
Image tag pr-funcd3eb7cf3c1
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcd3eb7cf3c1
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcd3eb7cf3c1
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcd3eb7cf3c1
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcd3eb7cf3c1
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcd3eb7cf3c1
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.81%. Comparing base (283e44f) to head (e5c5e96).

Files with missing lines Patch % Lines
pkg/cli/manifest/registermanifest.go 90.62% 1 Missing and 2 partials ⚠️
pkg/ucp/frontend/controller/resourcegroups/util.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8205      +/-   ##
==========================================
- Coverage   59.83%   59.81%   -0.02%     
==========================================
  Files         590      590              
  Lines       39520    39513       -7     
==========================================
- Hits        23646    23636      -10     
+ Misses      14119    14116       -3     
- Partials     1755     1761       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 10, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref c8c1be3
Unique ID func7bdea55e54
Image tag pr-func7bdea55e54
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func7bdea55e54
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func7bdea55e54
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func7bdea55e54
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func7bdea55e54
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func7bdea55e54
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details

@lakshmimsft lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from c8c1be3 to 07f1803 Compare January 10, 2025 22:43
@lakshmimsft lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 07f1803 to cf8042e Compare January 10, 2025 22:45
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 10, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref cf8042e
Unique ID func447998d1ea
Image tag pr-func447998d1ea
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func447998d1ea
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func447998d1ea
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func447998d1ea
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func447998d1ea
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func447998d1ea
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details

@lakshmimsft lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from cf8042e to e7ff53c Compare January 10, 2025 23:39
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 10, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref e7ff53c
Unique ID func97987471d5
Image tag pr-func97987471d5
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func97987471d5
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func97987471d5
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func97987471d5
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func97987471d5
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func97987471d5
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@lakshmimsft lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from e7ff53c to 11b4f4f Compare January 11, 2025 02:24
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 11, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref 11b4f4f
Unique ID funcdb51c7693a
Image tag pr-funcdb51c7693a
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcdb51c7693a
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcdb51c7693a
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcdb51c7693a
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcdb51c7693a
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcdb51c7693a
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

@lakshmimsft lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 11b4f4f to 923152d Compare January 13, 2025 21:28
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 13, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref 923152d
Unique ID func1ffb386327
Image tag pr-func1ffb386327
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1ffb386327
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1ffb386327
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func1ffb386327
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func1ffb386327
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1ffb386327
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@lakshmimsft lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 923152d to f860504 Compare January 14, 2025 00:32
@@ -46,15 +44,3 @@ type RadiusPlane struct {
func (p RadiusPlane) ResourceTypeName() string {
return p.Type
}

// LookupResourceProvider checks if the input provider is in the list of configured providers.
func (plane RadiusPlane) LookupResourceProvider(key string) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this for legacy routing to work?

@lakshmimsft lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 3a0e87d to c408ab9 Compare January 15, 2025 23:59
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 16, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref c408ab9
Unique ID func867454fe3c
Image tag pr-func867454fe3c
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func867454fe3c
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func867454fe3c
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func867454fe3c
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func867454fe3c
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func867454fe3c
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

nithyatsu
nithyatsu previously approved these changes Jan 17, 2025
nithyatsu
nithyatsu previously approved these changes Jan 17, 2025
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 17, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref 98ff3c4
Unique ID funcc041df9813
Image tag pr-funcc041df9813
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc041df9813
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc041df9813
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcc041df9813
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc041df9813
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc041df9813
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Signed-off-by: lakshmimsft <[email protected]>
Signed-off-by: lakshmimsft <[email protected]>
@lakshmimsft lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from a2dff60 to cbe8229 Compare January 17, 2025 22:49
@lakshmimsft lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from cbe8229 to 65243f6 Compare January 17, 2025 23:12
@lakshmimsft lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 65243f6 to 38e1740 Compare January 17, 2025 23:16
@lakshmimsft lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 38e1740 to 3e637de Compare January 17, 2025 23:32
@lakshmimsft lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 3e637de to e5c5e96 Compare January 17, 2025 23:33
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 17, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref e5c5e96
Unique ID funce67d8e2afc
Image tag pr-funce67d8e2afc
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funce67d8e2afc
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funce67d8e2afc
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funce67d8e2afc
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funce67d8e2afc
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funce67d8e2afc
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Comment on lines +293 to +308
echo "*** Verify manifests are registered ***"
rm -f registermanifest_logs.txt
# Find the pod with container "ucp"
POD_NAME=$(
kubectl get pods -n radius-system \
-o jsonpath='{range .items[*]}{.metadata.name}{" "}{.spec.containers[*].name}{"\n"}{end}' \
| grep "ucp" \
| head -n1 \
| cut -d" " -f1
)
echo "Found ucp pod: $POD_NAME"

if [ -z "$POD_NAME" ]; then
echo "No pod with container 'ucp' found in namespace radius-system."
exit 1
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be the case if the rad install command above succeeds. There should be a UCP pod for sure. Otherwise, we have a problem.

Comment on lines +310 to +328
# Poll logs for up to iterations, 30 seconds each (upto 3 minutes total)
for i in {1..6}; do
kubectl logs "$POD_NAME" -n radius-system | tee registermanifest_logs.txt > /dev/null

# Exit on error
if grep -qi "error" registermanifest_logs.txt; then
echo "Error found in ucp logs."
exit 1
fi

# Check for success
if grep -q "Successfully registered manifests" registermanifest_logs.txt; then
echo "Successfully registered manifests - message found."
break
fi

echo "Logs not ready, waiting 30 seconds..."
sleep 30
done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be looking for specific logs? This will error out in all types of errors.


# Final check to ensure success message was found
if ! grep -q "Successfully registered manifests" registermanifest_logs.txt; then
echo "Manifests not registered after 3 minutes."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be checked during rad install? Can this case happen after rad install successfully finishes? As a user, when rad install shows me success output, I wouldn't expect an error afterwards.

Comment on lines +47 to +50
for locationName, address = range resourceProvider.Location {
// We support one location per resourceProvider
break
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the for loop updates the locationName with the first location name from the map... We should add a not here.

expectedApiVersion = "2025-01-01-preview"
expectedApiVersion = "2023-10-01-preview"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other test resources have 2025 API version (I think and am not sure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants