Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detail layout and desc order as default on list view #208

Merged
merged 2 commits into from
Oct 29, 2021

Conversation

sumandari
Copy link
Collaborator

To fix:

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2021

Codecov Report

Merging #208 (61ab32a) into master (ef9e97d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   68.03%   68.03%           
=======================================
  Files          98       98           
  Lines        3785     3785           
=======================================
  Hits         2575     2575           
  Misses       1210     1210           
Impacted Files Coverage Δ
qgis-app/urls.py 92.30% <ø> (ø)
qgis-app/base/views/processing_view.py 79.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef9e97d...61ab32a. Read the comment docs.

Copy link
Member

@timlinux timlinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after typo fix

qgis-app/urls.py Outdated
'/styles/?is_galery=true',
'/geopackages/?is_galery=true',
'/models/?is_galery=true',
'/styles/?order_by=-upload_date&&is_galery=true',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change in your code galery to gallery

@sumandari sumandari merged commit e07461f into qgis:master Oct 29, 2021
@sumandari
Copy link
Collaborator Author

This PR has been deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants