Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 769: Fix some typos and provide some clarity #4192

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

warsaw
Copy link
Member

@warsaw warsaw commented Jan 8, 2025

@facundobatista

Hope you don't mind some tweaking of the wording!


📚 Documentation preview 📚: https://pep-previews--4192.org.readthedocs.build/

@warsaw warsaw requested a review from facundobatista as a code owner January 8, 2025 03:12
@AA-Turner AA-Turner changed the title Fix some typos and provide some clarity PEP 769: Fix some typos and provide some clarity Jan 8, 2025
Viicos

This comment was marked as outdated.

Copy link
Contributor

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe using proper Sphinx references will be cleaner, e.g.:

peps/pep-0769.rst Outdated Show resolved Hide resolved
@Viicos
Copy link
Contributor

Viicos commented Jan 8, 2025

I only gave an example, but ideally this should be applied on all the file. I can also do a separate PR.

@warsaw warsaw requested a review from a team January 9, 2025 00:54
@davep davep mentioned this pull request Jan 9, 2025
@hugovk
Copy link
Member

hugovk commented Jan 9, 2025

(conflict resolved)

peps/pep-0769.rst Show resolved Hide resolved
peps/pep-0769.rst Show resolved Hide resolved
Copy link
Member

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the suggestions!

@facundobatista facundobatista merged commit 83149c4 into python:main Jan 9, 2025
5 checks passed
@warsaw
Copy link
Member Author

warsaw commented Jan 9, 2025

Thanks @facundobatista - been too busy to finish it up, but glad you took over!

@warsaw warsaw deleted the warsaw/769-typos branch January 9, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants