Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align error message of _pyio.TextIOWrapper.seek with its C implementation #128852

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DimmaDont
Copy link

fix error message on seek of closed TextIOWrapper file in the python implementation of the io module

Copy link

cpython-cla-bot bot commented Jan 15, 2025

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jan 15, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link

@lazysegtree lazysegtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks @DimmaDont for finding this.

@picnixz
Copy link
Member

picnixz commented Jan 15, 2025

Can you confirm that this aligns with the C implementation of TextIOWrapper please?

@picnixz picnixz changed the title fix error message Align error message of _pyio.TextIOWrapper.seek with its C implementation Jan 15, 2025
@DimmaDont
Copy link
Author

should align now.
also is _reset_encoder() fine where it is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants