switch to uv and pyproject.toml #1776
Conversation
| [project] | ||
| name = "packaging-python-org" | ||
| version = "0.1.0" | ||
| description = "Overview of Python Packaging" | ||
| readme = "README.rst" | ||
| repository = "https://github.com/pypa/packaging.python.org" | ||
| documentation = "https://packaging.python.org/en/latest/" | ||
| requires-python = ">=3.9" | ||
| keywords = ["packaging", "518", "621"] | ||
| classifiers = [ | ||
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| ] | ||
| dependencies = [ | ||
| "furo==2024.8.6", | ||
| "sphinx-autobuild==2021.3.14", | ||
| "sphinx==7.2.6", | ||
| "sphinx-inline-tabs==2023.4.21", | ||
| "sphinx-copybutton==0.5.2", | ||
| "sphinx-toolbox==3.5.0", | ||
| ] | ||
|
|
There was a problem hiding this comment.
This project is not a distribution package, it must not have any packaging metadata as it's not supposed to be packaged as such.
| [project] | |
| name = "packaging-python-org" | |
| version = "0.1.0" | |
| description = "Overview of Python Packaging" | |
| readme = "README.rst" | |
| repository = "https://github.com/pypa/packaging.python.org" | |
| documentation = "https://packaging.python.org/en/latest/" | |
| requires-python = ">=3.9" | |
| keywords = ["packaging", "518", "621"] | |
| classifiers = [ | |
| "Programming Language :: Python", | |
| "Programming Language :: Python :: 3", | |
| "Programming Language :: Python :: 3.9", | |
| "Programming Language :: Python :: 3.10", | |
| "Programming Language :: Python :: 3.11", | |
| "Programming Language :: Python :: 3.12", | |
| "Programming Language :: Python :: 3.13", | |
| ] | |
| dependencies = [ | |
| "furo==2024.8.6", | |
| "sphinx-autobuild==2021.3.14", | |
| "sphinx==7.2.6", | |
| "sphinx-inline-tabs==2023.4.21", | |
| "sphinx-copybutton==0.5.2", | |
| "sphinx-toolbox==3.5.0", | |
| ] |
Using the dependency groups may be fine, provided that they list docs build environment deps.
| ] | ||
|
|
||
| [dependency-groups] | ||
| dev = [ |
There was a problem hiding this comment.
Why is this called dev? What's the difference from non-dev? Why is sphinx-lint installed in the same env as nox? Why is virtualenv needed?
| @@ -0,0 +1,17 @@ | |||
| # See https://docs.readthedocs.io/en/stable/config-file/v2.html for details | |||
There was a problem hiding this comment.
This is a deprecated filename that is warned about right at the top of the page, linked in this first line of the file. It must not be used.
| - asdf global uv latest | ||
| - asdf global uv latest | ||
| - uv sync --extra docs --frozen | ||
| - uv run -m sphinx -T -b html -d source/_build/doctrees source $READTHEDOCS_OUTPUT/html |
There was a problem hiding this comment.
Sphinx must remain integrated via nox.
|
Looking into this, I don't feel like this is a desired change overall. Especially with no justification and zero prior discussion. There's a bunch of integrations and assumption being broken (like nox being the central workflow tool) among other things. I don't think I'll be reviewing this anymore until there's at least some consensus among the maintainers that it's even slightly acceptable to look into replacing such a big chunk of automation with unclear gains. |
📚 Documentation preview 📚: https://python-packaging-user-guide--1776.org.readthedocs.build/en/1776/