Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ModifiedBetaGeoNBD and ModifiedBetaGeoNBDRV #1375

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

PabloRoque
Copy link
Contributor

@PabloRoque PabloRoque commented Jan 15, 2025

Description

This PR is equivalent to #1317, now tackling ModifiedBetaGeoNBD and ModifiedBetaGeoNBDRV.

  • Adds ModifiedBetaGeoNBD distribution
  • Adds ModifiedBetaGeoNBDRV
  • Introduces recency_frequency sampling from ModifiedBetaGeoNBD in ModifiedBetaGeoModel.distribution_new_customer

Related Issue

Checklist

Modules affected

  • MMM
  • CLV
  • Customer Choice

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 93.93939% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.90%. Comparing base (16db682) to head (b5c79dd).

Files with missing lines Patch % Lines
pymc_marketing/clv/distributions.py 93.22% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1375      +/-   ##
==========================================
- Coverage   93.92%   93.90%   -0.02%     
==========================================
  Files          48       48              
  Lines        5133     5188      +55     
==========================================
+ Hits         4821     4872      +51     
- Misses        312      316       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PabloRoque PabloRoque marked this pull request as ready for review January 15, 2025 15:35
@juanitorduz juanitorduz requested a review from ColtAllen January 15, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant