BetaGeoBetaBinomModel
Testing Speedup
#1039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The slow test
test_model_convergence
for the recently addedBetaGeoBetaBinomModel
takes over 90 minutes in the CI for the following reasons:Merging #707 will make MCMC sampling 3x faster, and although the full test dataset is still required elsewhere so that tests match research results and
lifetimes
outputs, for this particular slow test we can get away with a smaller dataset.test_model_convergence
is now being ran on a dataframe of 1k rows sampled from the full dataset. I had to bump up the rtol from 0.1 to 0.3 so that it passes, but added a comment the test did previously pass with the full dataset.Related Issue
Checklist
Modules affected
Type of change
📚 Documentation preview 📚: https://pymc-marketing--1039.org.readthedocs.build/en/1039/