Sphinx log parser fix #1556
Sphinx log parser fix #1556
Conversation
for more information, see https://pre-commit.ci
Pull Request Test Coverage Report for Build 10750632813Details
💛 - Coveralls |
Co-authored-by: freyso <[email protected]>
Co-authored-by: freyso <[email protected]>
|
@samwaseda can we merge this? |
| @@ -11,3 +11,4 @@ apidoc/ | |||
| .ipynb_checkpoints/ | |||
| test_times.dat | |||
| core.* | |||
| .vscode/settings.json | |||
There was a problem hiding this comment.
| .vscode/settings.json |
Or does this have a particular reason?
There was a problem hiding this comment.
I use vscode and it usually pushes changes in my settings to git sometimes
There was a problem hiding this comment.
I think it is very helpful for all vscode users, just like including the .idea/ folder in the .gitignore is helpful for Pycharm users. So we could debate if this should be a separate pull request, but in general I think it is a helpful addition.
| + "3+NIONS*0.5 for non-magnetic systems" | ||
| ) | ||
| else: | ||
| if self.input["EmptyStates"] < 0.5 * int(len(self.structure) + 3): |
There was a problem hiding this comment.
Isn't this normal for semi conductors? @skatnagallu @freyso
There was a problem hiding this comment.
For semiconductors this doesnt matter right? You shouldn't set it for semiconductors. And then SPHInX defaults to 0.
|
As suggested, I moved the changes to 3 PRs each dealing with different issues. Shall I close this PR and delete this branch? |
Fixes the issues mentioned here. All the mentioned issues were causing problems with restarted jobs. In my case restarted jobs for band structure calculations.