Patch emmet missing custodian #1210
Conversation
There was a problem hiding this comment.
LGTM too.
for the other repos, however, this will probably not yet fix the issue since they rely on the conda package if I recall correctly... thus, the feedstock would need a new build...
Yes, for sure. The feedstock will need a new release no matter what for the other repos to start working -- the only question is whether we want to make one new release (waiting for emmet-core to get a fixed release and then depend on that), or two new releases (merge and release this now, then again when emmet-core is fixed).
On the one hand, the materialsproject folks were super responsive the only other time I interacted with them, but on the other hand I'm suuuper tired of the tests failing... How about this: raise the issue on materialsproject/emmet, and if they fix it before Monday then we can stop worrying and make a single new version, but if they still haven't gotten to it then we can use the regular meeting to make sure the rest of the team is OK with a hotfix adding such an indirect dependency
|
Sorry, I was kind of busy today due to unforeseen circumstances. To accelerate this a bit, I opened an issue in the |
|
This got resolved via materialsproject/emmet#884 and our CI seems to be running well again. |
The materialsproject's
emmet-core, on which we depend viamp-api, is missing to declare its dependency oncustodian. This causes our CI and notebook runs to fail, with error messages likefrom custodian.vasp.jobs import VaspJob; ModuleNotFoundError: No module named 'custodian'. This patch provides a hotfix for this.Maybe this shouldn't be merged, as I will also raise an issue on
emmet's repo, as it's a cleaner solution if they declare this dependency explicitly.