Skip to content

Commit

Permalink
Update abseil-cpp version in top_level_CMakeLists.txt to restore test…
Browse files Browse the repository at this point in the history
…ing.

It is unclear what exactly broke testing with the standard command:

```
./scripts/google_run_tests.sh --make_jobs=48
```

```
/usr/local/google/home/rwgk/tmp/pybind11_abseil/tmp_build/_deps/abseil-cpp-src/absl/strings/internal/str_format/extension.h:34:6: warning: elaborated-type-specifier for a scoped enum must not use the ‘class’ keyword
   34 | enum class FormatConversionChar : uint8_t;
      | ~~~~ ^~~~~
      |      -----
/usr/local/google/home/rwgk/tmp/pybind11_abseil/tmp_build/_deps/abseil-cpp-src/absl/strings/internal/str_format/extension.h:34:33: error: found ‘:’ in nested-name-specifier, expected ‘::’
   34 | enum class FormatConversionChar : uint8_t;
      |                                 ^
      |                                 ::
```

Updating abseil-cpp to the same version as used in the bazel WORKSPACE file fixes the cmake build failures.

PiperOrigin-RevId: 574639457
  • Loading branch information
Ralf W. Grosse-Kunstleve authored and copybara-github committed Oct 18, 2023
1 parent bced1f0 commit 6c181d3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ find_package(PythonLibs REQUIRED)

FetchContent_Declare(
abseil-cpp
URL https://github.com/abseil/abseil-cpp/archive/refs/tags/20211102.0.tar.gz
URL https://github.com/abseil/abseil-cpp/archive/refs/tags/20230802.0.tar.gz
URL_HASH
SHA256=dcf71b9cba8dc0ca9940c4b316a0c796be8fab42b070bb6b7cab62b48f0e66c4)
SHA256=59d2976af9d6ecf001a81a35749a6e551a335b949d34918cfade07737b9d93c5)

FetchContent_Declare(
pybind11
Expand Down

0 comments on commit 6c181d3

Please sign in to comment.