Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up benchmarks by removing dead code from work_precision_sets #4771

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

vidipsingh
Copy link

  • Removed the entire work_precision_sets folder

Description

This PR removes the benchmarks/work_precision_sets folder, which contained dead code not currently in use by CI or other parts of the system. These files are supposed to be in the validation repository, which is not currently functioning. Removing them helps clean up unused parts of the codebase.

Fixes: #4766

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

- Removed the entire work_precision_sets folder
- Deleted all related dead code files
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (ef8571c) to head (418c8a7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4771   +/-   ##
========================================
  Coverage    98.69%   98.69%           
========================================
  Files          303      303           
  Lines        23226    23226           
========================================
  Hits         22923    22923           
  Misses         303      303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kratman kratman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to get rid of the workflow files

@vidipsingh
Copy link
Author

You also need to get rid of the workflow files

I believe you're referring to the work_precision_sets.yml file in the .github/workflows directory. I will go ahead and remove that file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove benchmarks/work_precision_sets and related files (dead code)
3 participants