Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yieldlab: Forward consent under param gdpr_consent #4127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rey1128
Copy link

@rey1128 rey1128 commented Jan 7, 2025

Description of change

consent should be forwarded under the param gdpr_consent to Yieldlab bidder

Other information

A review and approval from a member of the Yieldlab team are required. (@brushmate, @flanaras, @nkloeber or @william-harris)

Copy link

github-actions bot commented Jan 7, 2025

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b044066

yieldlab

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:31:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:41:	makeEndpointURL			98.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:128:	getDSA				100.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:146:	makeDSATransparencyURLParam	100.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:188:	makeFormats			100.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:207:	getGDPR				92.3%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:230:	makeTargetingValues		100.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:238:	MakeRequests			93.3%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:270:	parseRequest			80.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:290:	mergeParams			100.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:308:	MakeBids			78.9%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:399:	makeResponseExt			83.3%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:410:	findBidReq			80.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:422:	extractAdslotID			100.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:430:	makeBannerAdSource		100.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:434:	makeVast			100.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:438:	makeAdSourceURL			100.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:457:	makeCreativeID			100.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:462:	unmarshalSupplyChain		80.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:473:	makeSupplyChain			100.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:501:	makeNodeValue			92.9%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:527:	splitSize			100.0%
github.com/prebid/prebid-server/v3/adapters/yieldlab/yieldlab.go:548:	impIsTypeBannerOnly		100.0%
total:									(statements)			93.3%

Copy link

@william-harris william-harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo changed the title YieldlabBidAdapter forward consent under param gdpr_consent Yieldlab: Forward consent under param gdpr_consent Jan 7, 2025
@bsardo bsardo added the adapter label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants