New Adapter: Bidtheatre #4069
New Adapter: Bidtheatre #4069
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| var bidExt openrtb_ext.ExtBid | ||
| err := jsonutil.Unmarshal(bid.Ext, &bidExt) | ||
| if err == nil && bidExt.Prebid != nil { | ||
| return openrtb_ext.ParseBidType(string(bidExt.Prebid.Type)) |
There was a problem hiding this comment.
Consider this as a suggestion. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, recommends implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
Code coverage summaryNote:
bidtheatreRefer here for heat map coverage report |
| - video | ||
| userSync: | ||
| redirect: | ||
| url: https://match.adsby.bidtheatre.com/usersync?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&cb={{.RedirectURL}} |
There was a problem hiding this comment.
for redirect we should get 302 not 200
There was a problem hiding this comment.
Hi @przemkaczmarek ,
We require redirect domains to be explicitly whitelisted to perform the redirect, so in this case no redirect is actually made. This means we will need to whitelist each onboarded publisher's prebid-server domain.
See correct 302 redirect for this whitelisted domain as an example:
https://match.adsby.bidtheatre.com/usersync?gdpr=0&gdpr_consent=&cb=https%3A%2F%2Fid5-sync.com%3Fuid%3D%7Buid%7D
There was a problem hiding this comment.
Is this approach acceptable @przemkaczmarek ?
|
@Rothalack can you please review? |
|
@pm-nikhil-vaidya can you please review? |
|
Sure @bsardo |
|
I have no additional feedback for this PR. Looks good to me. You'll probably want to flip pbs support to true on the docs whenever this goes out. |
| } | ||
| price := strconv.FormatFloat(bid.Price, 'f', -1, 64) | ||
| bid.NURL = strings.Replace(bid.NURL, "${AUCTION_PRICE}", price, -1) | ||
| bid.AdM = strings.Replace(bid.AdM, "${AUCTION_PRICE}", price, -1) |
There was a problem hiding this comment.
Can we handle the macro replacement directly within the adapter? Is there a specific reason why it's being done here instead?
There was a problem hiding this comment.
This function is private to the adapter. What exactly do you mean?
There was a problem hiding this comment.
I want to know reason to replace macro here instead of replacing at adapter side while sending out the response
There was a problem hiding this comment.
I'm sorry but I don't fully understand what I've done wrong here. What I tried to do was to fulfill this recommendation
We recommend resolving creative OpenRTB macros in your adapter. Otherwise, AUCTION_PRICE will eventually get resolved by the Prebid Universal Creative, but by then the bid price will be in the ad server currency and quantized by the price granularity.
from here: https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html
and in general just make sure that all occurrences of ${AUCTION_PRICE} are accurately replaced with the bid/winning price.
How do you suggest this is better done?
|
Thank you all for your feedback, we will review your comments in detail and address them shortly. |
Docs: prebid/prebid.github.io#5723
Prebid.js: prebid/Prebid.js#12485