Consumable Bid Adapter: remove EID non-objects

[jpiros]

Type of change

• Bugfix

• Feature

• New bidder adapter

• Updated bidder adapter

• Code style update (formatting, local variables)

• Refactoring (no functional changes, no api changes)

• Build related changes

• CI related changes

• Does this change affect user-facing APIs or examples documented on http://prebid.org?

• Other

Description of change

This change removes non-objects from the user EIDs array, ensuring only objects are passed to the bidder.

Other information

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/connectadBidAdapter.js has 25 duplicated lines with modules/consumableBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[patmmccann]

it feels like the userid module itself should handle this. Do you have a test page where this occurs?

[travisbeale]

Hi @patmmccann, unfortunately we don't have a test page. We have been seeing this intermittently with a few of our publisher partners that have been sending invalid eids sections intermittently. Here is an example of an invalid eids section that we have seen in the wild. I have replaced all user ids with "aaa".

"eids": [
            {
                "source": "33across.com",
                "uids": [
                    {
                        "id": "33acrossId_SINCERA_TRACKING_IDENTIFIER",
                        "atype": 1
                    }
                ]
            },
            {
                "source": "criteo.com",
                "uids": [
                    {
                        "id": "criteo_SINCERA_TRACKING_IDENTIFIER",
                        "atype": 1
                    }
                ]
            },
            {
                "source": "neustar.biz",
                "uids": [
                    {
                        "id": "aaa",
                        "atype": 1
                    }
                ]
            },
            {
                "source": "id5-sync.com",
                "uids": [
                    {
                        "id": "aaa",
                        "atype": 1,
                        "ext": {
                            "linkType": 2,
                            "pba": "aaa"
                        }
                    }
                ]
            },
            "pubProvidedId_SINCERA_TRACKING_IDENTIFIER",
            {
                "source": "pubcid.org",
                "uids": [
                    {
                        "id": "aaa",
                        "atype": 1
                    }
                ]
            }
        ]