EPlanning Bid Adapter: Adding support for schain #12635
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
requested changes
Jan 10, 2025
| @@ -70,7 +72,9 @@ export const spec = { | |||
| if (pcrs) { | |||
| params.crs = pcrs; | |||
| } | |||
|
|
|||
| if (Math.floor(Math.random() * 1000) === 0 && schain) { | |||
There was a problem hiding this comment.
As schain does not change all the time, we only need to receive it once every 1000 requests. Then we use a cache on our side until the next request. This way we reduce the requests size
There was a problem hiding this comment.
you might get different schains from different units on the same page.
There was a problem hiding this comment.
And if someone sets an schain rid, it changes every time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change