Skip to content

Commit

Permalink
feat(clusterapi-resource): Parameterize snat (#33)
Browse files Browse the repository at this point in the history
### PR Description
Depending on the cluster we may have a different SNAT that can be used.
This PR allows override of it.

### Checklist

- [x] Have you reviewed and updated the chart default values if
necessary?
- [ ] Have you reviewed and updated the chart documentation if
necessary?
- [ ] Does your branch follow the naming convention of
`{chartNameWithDashes}-v{versionString}-{optionalPatchVersion}`?
 - [x] Have you bumped the version in the chart's `Chart.yaml`?

### Tagged Releases
Please remember to make a tagged release after merging your PR that:

 - Has a tag name that matches your PR branch name (see above)
 - Has a description that summarizes the changes made

This makes it possible to use previous versions of the charts maintained
here as new releases are published. Please see the release history of
this repository for examples.

Signed-off-by: Igor Valente Blackman <[email protected]>
  • Loading branch information
iblackman authored Nov 20, 2024
1 parent 58cf971 commit 83bcd26
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ data:
"bigip": "/Common/fastL4"
},
"snat": {
"bigip": "/Common/SNATPool"
"bigip": "{{ .Values.bigipCtrlAS3.snatPool }}"
},
"virtualPort": {{ .Values.bigipCtrlAS3.kubeapi.vs.port }},
"remark": "{{ .Values.cluster.name }} kubeapi vs",
Expand Down Expand Up @@ -74,7 +74,7 @@ data:
}
},
"snat": {
"bigip": "/Common/SNATPool"
"bigip": "{{ .Values.bigipCtrlAS3.snatPool }}"
},
"virtualPort": 443,
"remark": "{{ .Values.cluster.name }} ingress vs",
Expand Down Expand Up @@ -110,7 +110,7 @@ data:
}
},
"snat": {
"bigip": "/Common/SNATPool"
"bigip": "{{ .Values.bigipCtrlAS3.snatPool }}"
},
"virtualPort": 80,
"remark": "{{ .Values.cluster.name }} ingress vs",
Expand Down
1 change: 1 addition & 0 deletions charts/clusterapi-resources/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ extraResourcesSecrets: []

# Creates bigip-ctrl AS3 configmap for kubeapi endpoint with manual list of pool members
bigipCtrlAS3:
snatPool: "/Common/SNAT-Pool-List"
kubeapi:
enabled: false
# vs:
Expand Down

0 comments on commit 83bcd26

Please sign in to comment.