-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GT.opt_all_caps()
#436
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
+ Coverage 86.37% 86.88% +0.50%
==========================================
Files 42 42
Lines 4683 4674 -9
==========================================
+ Hits 4045 4061 +16
+ Misses 638 613 -25 ☔ View full report in Codecov by Sentry. |
b1197c4
to
d932df5
Compare
d932df5
to
f0ae1a7
Compare
@rich-iannone and @machow , sorry for the messy commits. The reason for this is that while trying to modify the Currently, the type annotation and initial value of |
Thanks for bringing up the related issue. Initially, I was thinking of using a |
Sorry for the wait, now that the new location stuff is merged in, I can take a look at this next week |
I'm curious if
GT.opt_all_caps()
can be refactored as suggested in this PR.