Remove some unnecessary @unchecked Sendables. #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -677,13 +676,12 @@ where Base.Value: Hashable { | |||
| } | |||
| } | |||
|
|
|||
| private final class _UIBindingEnumToOptionalCase<Base: _UIBinding, Case>: _UIBinding, @unchecked | |||
| Sendable | |||
| private final class _UIBindingEnumToOptionalCase<Base: _UIBinding, Case>: _UIBinding | |||
There was a problem hiding this comment.
This lose the Sendable? Or is it implicit and can we remove the explicit one above?
Suggested change
| private final class _UIBindingEnumToOptionalCase<Base: _UIBinding, Case>: _UIBinding | |
| private final class _UIBindingEnumToOptionalCase<Base: _UIBinding, Case>: _UIBinding, Sendable |
Or should it be conditional?
There was a problem hiding this comment.
_UIBinding is : Sendable so we already get it.
stephencelis
approved these changes
Sep 25, 2024
Comment on lines
2
to
3
| public typealias _KeyPath<Root, Value> = any KeyPath<Root, Value> & Sendable | ||
| public typealias _WritableKeyPath<Root, Value> = any WritableKeyPath<Root, Value> & Sendable |
There was a problem hiding this comment.
Wonder if we make this explicit for readability:
Suggested change
| public typealias _KeyPath<Root, Value> = any KeyPath<Root, Value> & Sendable | |
| public typealias _WritableKeyPath<Root, Value> = any WritableKeyPath<Root, Value> & Sendable | |
| public typealias _SendableKeyPath<Root, Value> = any KeyPath<Root, Value> & Sendable | |
| public typealias _SendableWritableKeyPath<Root, Value> = any WritableKeyPath<Root, Value> & Sendable |
There was a problem hiding this comment.
Yep good idea, done! I can do that over in TCA too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few
@unchecked Sendables that aren't really necessary, so cleaning them up.