Delay UIAlertController.onDismiss
#201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `onDismiss` is called _before_ the `UIAlertAction` is processed, which generally isn't an issue, but if you care about the order of operations, this can be a bit thorny. In the case of highly generalized navigation patterns in TCA, the order is what we use to emit warnings when invalid actions are received (like a `dismiss` action is received for an already-dismissed feature), so let's address the problem with a quick tick. We could do this thread hop unconditionally if it makes sense to, but let's localize to `UIAlertController` for now.
mbrandonw
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
onDismissis called before theUIAlertActionis processed, which generally isn't an issue, but if you care about the order of operations, this can be a bit thorny. In the case of highly generalized navigation patterns in TCA, the order is what we use to emit warnings when invalid actions are received (like adismissaction is received for an already-dismissed feature), so let's address the problem with a quick tick.We could do this thread hop unconditionally if it makes sense to, but let's localize to
UIAlertControllerfor now.