Fix AlertState.init availability
#198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In SwiftUI Navigation 1.0, `AlertState` had many initializers to match the various interfaces in SwiftUI, and they matched the availability of the SwiftUI interfaces. We simplified to a single interface in 2.0, but didn't consider the availability mismatch. While we could bring back the old APIs, it might be nice to favor the modern builder style. The one caveat is that it will be possible to render alerts pre-iOS 15 that are configured with more than the maximum 2 buttons at that time. We can emit a runtime warning if we detect this, but we are losing some of the compile-time check of the previous version.
mbrandonw
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SwiftUI Navigation 1.0,
AlertStatehad many initializers to match the various interfaces in SwiftUI, and they matched the availability of the SwiftUI interfaces. We simplified to a single interface in 2.0, but didn't consider the availability mismatch.While we could bring back the old APIs, it might be nice to favor the modern builder style. The one caveat is that it will be possible to render alerts pre-iOS 15 that are configured with more than the maximum 2 buttons at that time. We can emit a runtime warning if we detect this, but we are losing some of the compile-time check of the previous version.