Deprecate preview dependencies trait #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a quirk or bug or Xcode previews, dependency traits are executed for every preview in a file, not just the one that's running. This can cause dependencies from other previews to trample over the preview you are viewing. Because of this, let's deprecate this functionality in favor of good ole fashioned `withDependencies`, with the option of using `prepareDependencies`.
stephencelis
commented
Dec 30, 2024
Comment on lines
+246
to
+249
| fileID: key.fileID, | ||
| filePath: key.filePath, | ||
| line: key.line, | ||
| column: key.column |
There was a problem hiding this comment.
Noticed the lack of labels when fixing docs. This is technically breaking but I don't think anyone should be invoking these arguments directly outside the library and there's a fix-it to add the labels, but if we're worried I can undo this.
stephencelis
commented
Dec 30, 2024
| @@ -1,7 +1,7 @@ | |||
| import Foundation | |||
|
|
|||
| extension Thread { | |||
| public static var isPreviewAppEntryPoint: Bool { | |||
There was a problem hiding this comment.
Accidentally made this public in the previous release.
mbrandonw
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a quirk or bug or Xcode previews, dependency traits are executed for every preview in a file, not just the one that's running. This can cause dependencies from other previews to trample over the preview you are viewing.
Because of this, let's deprecate this functionality in favor of good ole fashioned
withDependencies, with the option of usingprepareDependencies.