Allow preparing dependency multiple times in same scope #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
changed the title
stephencelis
approved these changes
Nov 5, 2024
stephencelis
added a commit
that referenced
this pull request
Nov 7, 2024
* Add `prepareDependencies`
Right now, dependencies can only be overridden using scoped operations
like `withDependencies` or attached to object livecycles
(`withDependencies(from:)`). This introduces a new top-level way of
preparing global dependencies so that they are accessible in the
top-level scope of your application.
* wip
* wip
* wip
* Add failing test for preparing dependency twice in the same prepareDependencies{}
* another failing test
* wip
* Allow preparing dependency multiple times in same scope (#298)
* Attempted fix of preparing dependency in multiple lines.
* fixes
* fix
* tests
* wip
* fixes
* clean up
* clean up
* clean up
* wip
* wip
* fix
* wip
* wip
* wip
---------
Co-authored-by: Brandon Williams <[email protected]>
Co-authored-by: Brandon Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #288 and fixes a few problems with preparing a dependency multiple times in the same lexical scope. We need to allow this in order for it to be useful.
It still does not allow for a dependency to be prepared from multiple
prepareDependencies. Even if the dependency was never accessed. We may weaken that restriction in the future if it proves to be useful.