Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PUBLISH.md to clarify build steps #326

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Update PUBLISH.md to clarify build steps #326

merged 1 commit into from
Oct 26, 2023

Conversation

tzha-plaid
Copy link
Contributor

  • Clarifies that manual publish steps using npm only work if the package has already been built via make

@tzha-plaid tzha-plaid requested review from itsvs and FlaggIgbo October 26, 2023 21:51
FlaggIgbo
FlaggIgbo approved these changes Oct 26, 2023
View reviewed changes
Copy link

@FlaggIgbo FlaggIgbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♠️

@tzha-plaid tzha-plaid merged commit fd5e476 into master Oct 26, 2023
1 of 2 checks passed
@tzha-plaid tzha-plaid deleted the tzha-plaid-patch-1 branch October 26, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlaggIgbo FlaggIgbo FlaggIgbo approved these changes

@itsvs itsvs Awaiting requested review from itsvs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tzha-plaid @FlaggIgbo