Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+starship #105

Merged
merged 2 commits into from
Jan 14, 2023
Merged

+starship #105

merged 2 commits into from
Jan 14, 2023

Conversation

johnallen3d
Copy link
Contributor

Adds the Starship prompt.

@johnallen3d
Copy link
Contributor Author

This is on the top 300 list.

@what-the-diff
Copy link

what-the-diff bot commented Jan 6, 2023

  • Added a new file
  • Changed the mode of an existing file
  • Deleted an existing file

@johnallen3d johnallen3d marked this pull request as draft January 6, 2023 16:19
@jhheider
Copy link
Contributor

jhheider commented Jan 6, 2023

CMake Error: CMake was unable to find a build program corresponding to "Unix Makefiles". CMAKE_MAKE_PROGRAM is not set. You probably need to select a different build tool.

Likely needs a build-dep on tea.xyz/gx/make: '*'.

@johnallen3d johnallen3d force-pushed the starship branch 2 times, most recently from a4cb3cd to b1ca3bf Compare January 6, 2023 22:02
@johnallen3d johnallen3d marked this pull request as ready for review January 6, 2023 22:22
@mxcl
Copy link
Member

mxcl commented Jan 8, 2023

First package that probs needs some follow up instructions or the user is left without a clue on how to use it.

brew used a caveats key. With time it was apparent caveats were usually just “fyi”s, so some equivalent.

Longer term would be great to have some awareness of shell-additions built in to tea in some manner. Presumably via our shell magic additions.

@jhheider
Copy link
Contributor

Looks like this is the test failure:

+ starship version
error: The subcommand 'version' wasn't recognized

  Did you mean 'session'?

  If you believe you received this message in error, try re-running with 'starship -- version'

Usage: starship <COMMAND>

For more information try '--help'

Should be an easy fix, if that's all of it.

Adds the Starship prompt.
@johnallen3d
Copy link
Contributor Author

Good catch, thanks @jhheider. I've made the updated... I did review the available commands but couldn't identify an option that would work universally across build systems to test with.

@mxcl
Copy link
Member

mxcl commented Jan 14, 2023

Has a homepage https://starship.rs we should name the package that.

@mxcl
Copy link
Member

mxcl commented Jan 14, 2023

I'll merge and rename

@mxcl mxcl merged commit 4fea17c into pkgxdev:main Jan 14, 2023
mxcl pushed a commit that referenced this pull request Jan 14, 2023
* +starship

Adds the Starship prompt.

* fix test
@johnallen3d johnallen3d deleted the starship branch January 14, 2023 20:23
mxcl added a commit that referenced this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants