Fix gcc build

Signed-off-by: Dom Del Nano <[email protected]>
pixie-io · Jan 16, 2025 · 2b36223 · 2b36223
1 parent 955ca1b
commit 2b36223
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/common/exec/exec.cc b/src/common/exec/exec.cc
@@ -24,8 +24,16 @@
 
 namespace px {
 
+// GCC's ingnored-attribute warning is triggered without wrapping pclose. This is likely do to the
+// nonnull attribute.
+struct pclose_deleter {
+  void operator()(FILE* file) const {
+    pclose(file);
+  }
+};
+
 StatusOr<std::string> Exec(std::string cmd) {
-  std::unique_ptr<FILE, decltype(&pclose)> pipe(popen(cmd.c_str(), "r"), pclose);
+  std::unique_ptr<FILE, pclose_deleter> pipe(popen(cmd.c_str(), "r"));
   if (pipe == nullptr) {
     return error::Internal("popen() failed!");
   }

diff --git a/src/e2e_test/vizier/planner/BUILD.bazel b/src/e2e_test/vizier/planner/BUILD.bazel
@@ -24,7 +24,6 @@ pl_go_test(
     ],
     tags = [
         "no_asan",
-        "no_gcc",
         "no_msan",
         "no_tsan",
     ],