Upgrade Gatsby and MUI #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for docs-px-dev failed.
|
NickLanam
suggested changes
Aug 23, 2022
Comment on lines
-6
to
-7
| redirect_from: | ||
| - /tutorials/pxl-scripts |
There was a problem hiding this comment.
- Added npmrc file to resolve dependency conflicts on
npm install. - was getting error:
There are routes that match both page and redirect. Pages take precedence over redirects so the redirect
will not work:
- page: "/tutorials/pxl-scripts/" and redirect: "/tutorials/pxl-scripts" ->
"/tutorials/pxl-scripts/write-pxl-scripts"
Found 2 ways to solve this either remove redirect_from or to change it redirect_from: /tutorials/write-pxl-scripts
NickLanam
suggested changes
Aug 24, 2022
There was a problem hiding this comment.
It's still not building, but for a very easily fixed reason: this project normally uses Yarn, not NPM, but the PR has switched it. Removing node_modules and package-lock.json, then running yarn install (NOT npm install) made it work again locally for me. I don't think .npmrc is needed either for this reason.
tanisha-agarwal
force-pushed
the
upgrade_gatsby
branch
from
17aefc8 to
79680db
Compare
Signed-off-by: Tanisha Agarwal <[email protected]>
tanisha-agarwal
force-pushed
the
upgrade_gatsby
branch
from
79680db to
4a5f101
Compare
tanisha-agarwal
requested review from
NickLanam
and removed request for
aimichelle
NickLanam
reviewed
Sep 1, 2022
package.json
Outdated
Comment on lines
81
to
114
| "react": "^17.0.1", | ||
| "react-body-classname": "^1.3.1", | ||
| "react-dom": "^17.0.2", | ||
| "react-emotion": "^10.0.0", | ||
| "react-helmet": "^6.1.0", | ||
| "react-helmet": "^5.2.1", | ||
| "react-live": "^2.2.3", | ||
| "react-markdown": "^8.0.3", | ||
| "react-scrollspy": "^3.4.3", | ||
| "remark-containers": "^1.2.0", | ||
| "sass": "^1.54.4", | ||
| "slugify": "^1.6.5", | ||
| "slugify": "^1.3.6", | ||
| "styled-components": "^5.3.0", | ||
| "typescript": "^4.7.4", | ||
| "unist-util-visit": "^2.0.3" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/node": "^18.7.2", | ||
| "@types/react": "^18.0.17", | ||
| "@types/react-dom": "^18.0.6", | ||
| "@types/react-helmet": "^5.0.15", | ||
| "@typescript-eslint/eslint-plugin": "^5.33.0", | ||
| "@typescript-eslint/parser": "^5.33.0", | ||
| "eslint": "^8.21.0", | ||
| "@types/js-cookie": "^3.0.1", | ||
| "@types/mdx-js__react": "^1.5.5", | ||
| "@types/node": "^17.0.21", | ||
| "@types/react": "^17.0.39", | ||
| "@types/react-dom": "^17.0.13", | ||
| "@types/react-helmet": "^6.1.5", | ||
| "@typescript-eslint/eslint-plugin": "^5.20.0", | ||
| "@typescript-eslint/parser": "^5.20.0", | ||
| "eslint": "^7.16.0", | ||
| "eslint-config-airbnb": "^19.0.4", | ||
| "eslint-config-airbnb-typescript": "^17.0.0", | ||
| "eslint-config-standard": "^17.0.0", | ||
| "eslint-plugin-import": "^2.26.0", | ||
| "eslint-plugin-jsx-a11y": "^6.6.1", | ||
| "eslint-plugin-node": "^11.1.0", | ||
| "eslint-plugin-promise": "^6.0.0", | ||
| "eslint-plugin-react": "^7.30.1", | ||
| "eslint-plugin-react-hooks": "^4.6.0", | ||
| "prettier": "^2.7.1" | ||
| "eslint-config-standard": "^14.1.0", | ||
| "eslint-plugin-import": "^2.20.1", | ||
| "eslint-plugin-node": "^11.0.0", | ||
| "eslint-plugin-promise": "^4.2.1", | ||
| "eslint-plugin-react": "^7.29.4", | ||
| "eslint-plugin-react-hooks": "^4.4.0", | ||
| "prettier": "^1.17.1", | ||
| "typescript": "^4.6.2" |
There was a problem hiding this comment.
It seems most of these are package downgrades - including a point release of TypeScript and a patch release of React. Even a major version of Prettier. I understand the rest of the package downgrades, but why these three?
EDIT: I was looking at the commit relative to its predecessor, I see now this is putting them back to how they are in the base branch. Sorry about that!
There was a problem hiding this comment.
@NickLanam @htroisi Upgraded some package back to latest version as were in first commit
htroisi
reviewed
Sep 1, 2022
| @@ -1285,7 +1285,7 @@ | |||
| "def": { | |||
| "name": "class Client", | |||
| "declaration": "Client(self, token: str, server_url: str = 'work.withpixie.ai', use_encryption: bool = False, channel_fn: Callable[[str], grpc.Channel] = None, conn_channel_fn: Callable[[str], grpc.aio._base_channel.Channel] = None )", | |||
| "docstring": "Client is the main entry point to the Pixie API.\n\nTo setup the client, you need to generate an API token\nand pass it in as the first argument.\nSee: https://docs.px.dev/using-pixie/api-quick-start/\nfor more info." | |||
| "docstring": "Client is the main entry point to the Pixie API.\n\nTo setup the client, you need to generate an API token\nand pass it in as the first argument.\nSee: [https://docs.px.dev/using-pixie/api-quick-start/](https://docs.px.dev/using-pixie/api-quick-start/)\nfor more info." | |||
There was a problem hiding this comment.
This file is produced automatically from code in the main pixie repo. We'll need to upstream any changes to this file there & also make sure that this works with the other docs repo.
Signed-off-by: Tanisha Agarwal <[email protected]>
tanisha-agarwal
force-pushed
the
upgrade_gatsby
branch
from
4a5f101 to
eecca48
Compare
Signed-off-by: Nick Lanam <[email protected]>
Signed-off-by: Nick Lanam <[email protected]>
Signed-off-by: Nick Lanam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #102
Signed-off-by: Tanisha Agarwal [email protected]