Add support for rtcp-fb:* (Chrome PSA) #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #152 +/- ##
==========================================
+ Coverage 64.67% 64.96% +0.29%
==========================================
Files 12 12
Lines 1571 1587 +16
==========================================
+ Hits 1016 1031 +15
- Misses 454 455 +1
Partials 101 101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stv0g
force-pushed
the
feat/wildcard-rtcp-fb
branch
2 times, most recently
from
38eca8b to
a243a01
Compare
|
Lets a wait a bit more until its merged into Chrome. Currently, it has not made it into 112: https://groups.google.com/g/discuss-webrtc/c/Y_h2B-NOzW0/m/26SqldfuAgAJ |
|
And why wait for Chrome if it is already described in the RFC? |
|
Sorry I didn't merge this sooner! LGTM merging now, will also update pion/webrtc to respect these values |
Sean-Der
force-pushed
the
feat/wildcard-rtcp-fb
branch
from
a243a01 to
fd4f6e0
Compare
According to Chrome PSA: https://groups.google.com/g/discuss-webrtc/c/Y_h2B-NOzW0 rtcp-fb:* might start getting sent by chrome in M112. This was rolled back but may land again in M114 according to maintainers. Also, according to https://webrtc.googlesource.com/src.git/+/8155227/#F0 Chrome may plan on sending both rtcp-fb:* and rtcp-fb:<int> variants for some time to allow migration in downstream projects. This change correctly parses the wildcard case to add the feedback to all payload types found in the SDP, to maintain compatibility with Pion. Resolves pion#172
Sean-Der
force-pushed
the
feat/wildcard-rtcp-fb
branch
from
fd4f6e0 to
b7d0ec1
Compare
Sean-Der
approved these changes
Mar 29, 2024
|
Amazing work @thebongy I am sorry this took so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to Chrome PSA: https://groups.google.com/g/discuss-webrtc/c/Y_h2B-NOzW0
rtcp-fb:*might start getting sent by chrome in M112. For more information, refer to "wildcard" defined in (https://www.rfc-editor.org/rfc/rfc4585.html#section-4.2)This was rolled back in M112 as it broke a few projects, but may land again in M114 according to maintainers.
Also, according to https://webrtc.googlesource.com/src.git/+/815522782a92e168b80edc760b2e53e4d0e4ea0d%5E!/#F0 chrome may plan on sending both
rtcp-fb:*andrtcp-fb:<int>variants for some time to allow migration in downstream projects. This change correctly parses the wildcard case to add the feedback to all payload types found in the SDP, to maintain compatibility with pion project.