Fix fmtp parsing with spaces inside

pion · Jan 9, 2025 · f198008 · f198008
1 parent d518314
commit f198008
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/util.go b/util.go
@@ -140,7 +140,7 @@ func parseFmtp(fmtp string) (Codec, error) {
 	parsingFailed := errExtractCodecFmtp
 
 	// a=fmtp:<format> <format specific parameters>
-	split := strings.Split(fmtp, " ")
+	split := strings.SplitN(fmtp, " ", 2)
 	if len(split) != 2 {
 		return codec, parsingFailed
 	}

diff --git a/util_test.go b/util_test.go
@@ -19,17 +19,19 @@ func getTestSessionDescription() SessionDescription {
 						Value: 51372,
 					},
 					Protos:  []string{"RTP", "AVP"},
-					Formats: []string{"120", "121", "126", "97"},
+					Formats: []string{"120", "121", "126", "97", "98"},
 				},
 				Attributes: []Attribute{
 					NewAttribute("fmtp:126 profile-level-id=42e01f;level-asymmetry-allowed=1;packetization-mode=1", ""),
 					NewAttribute("fmtp:97 profile-level-id=42e01f;level-asymmetry-allowed=1", ""),
+					NewAttribute("fmtp:98 profile-level-id=42e01e; packetization-mode=1", ""),
 					NewAttribute("fmtp:120 max-fs=12288;max-fr=60", ""),
 					NewAttribute("fmtp:121 max-fs=12288;max-fr=60", ""),
 					NewAttribute("rtpmap:120 VP8/90000", ""),
 					NewAttribute("rtpmap:121 VP9/90000", ""),
 					NewAttribute("rtpmap:126 H264/90000", ""),
 					NewAttribute("rtpmap:97 H264/90000", ""),
+					NewAttribute("rtpmap:98 H264/90000", ""),
 					NewAttribute("rtcp-fb:97 ccm fir", ""),
 					NewAttribute("rtcp-fb:97 nack", ""),
 					NewAttribute("rtcp-fb:97 nack pli", ""),
@@ -148,6 +150,18 @@ func TestGetCodecForPayloadType(t *testing.T) {
 				RTCPFeedback: []string{"ccm fir", "nack", "nack pli", "transport-cc"},
 			},
 		},
+		{
+			"h264 98",
+			getTestSessionDescription(),
+			98,
+			Codec{
+				PayloadType:  98,
+				Name:         "H264",
+				ClockRate:    90000,
+				Fmtp:         "profile-level-id=42e01e; packetization-mode=1",
+				RTCPFeedback: []string{"transport-cc", "nack"},
+			},
+		},
 		{
 			"pcmu without rtpmap",
 			SessionDescription{