Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button - always light/dark variants (Classic, VR) #3931

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gabrielpereirapinheiro
Copy link
Contributor

@gabrielpereirapinheiro gabrielpereirapinheiro commented Jan 9, 2025

Adding two new variants

Classic

  • AlwaysLight
Screenshot 2025-01-09 at 08 30 24
  • AlwaysDark
Screenshot 2025-01-09 at 08 29 23

VR

  • AlwaysLight
Screenshot 2025-01-09 at 08 32 13
  • AlwaysDark
Screenshot 2025-01-09 at 08 31 40

@gabrielpereirapinheiro gabrielpereirapinheiro requested a review from a team as a code owner January 9, 2025 16:32
@AlbertCarreras AlbertCarreras added the minor release Minor release label Jan 13, 2025
@AlbertCarreras
Copy link
Contributor

@gabrielpereirapinheiro Can we do this also for ButtonLink

@@ -201,3 +201,11 @@ a.lgVr:focus {
.white:active {
background-color: var(--color-background-button-white-active);
}

.alwaysLight {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename to dark and light

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor release Minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants